Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup all warnings in 5.9 build #1125

Open
ktoso opened this issue Jul 3, 2023 · 1 comment
Open

Cleanup all warnings in 5.9 build #1125

ktoso opened this issue Jul 3, 2023 · 1 comment
Assignees
Labels
1 - triaged Ticket makes sense and is well defined, ready to be worked on 2 - pick next If looking for work, pick this ticket :-) help wanted Great tickets to get started contributing!
Milestone

Comments

@ktoso
Copy link
Member

ktoso commented Jul 3, 2023

We have a lot of self induced "deprecation warnings" because we use the runtime that people should not be touching.

  • We should probably remove a bunch of those deprecations because they are not types the public API exposes and we just have the noise to suffer through it.
  • We should consistently remove those deprecated "actor ref" APIs
  • We should address new warnings that appear in the 5.9 build
@ktoso ktoso self-assigned this Jul 3, 2023
@ktoso ktoso added this to the 1.0.x milestone Jul 3, 2023
@ktoso
Copy link
Member Author

ktoso commented Jul 3, 2023

There's a lot of these annoying ones:

/Users/ktoso/code/swift-distributed-actors/Sources/DistributedCluster/ClusterSystem.swift:833:38: warning: conformance of 'Never' to 'Encodable' is only available in macOS 14.0 or newer
        guard let selector = context.selectorSegments.first else {
                                     ^
/Users/ktoso/code/swift-distributed-actors/Sources/DistributedCluster/ClusterSystem.swift:833:38: note: add 'if #available' version check
        guard let selector = context.selectorSegments.first else {
                                     ^
/Users/ktoso/code/swift-distributed-actors/Sources/DistributedCluster/ClusterSystem.swift:832:10: note: add @available attribute to enclosing instance method
    func _resolveUntyped(context: _ResolveContext<Never>) -> _AddressableActorRef {
         ^

due to Never gaining a Codable conformance as well

@ktoso ktoso changed the title Must cleanup amount of warnings in 5.9 build Cleanup all warnings in 5.9 build Jul 3, 2023
@ktoso ktoso added help wanted Great tickets to get started contributing! 1 - triaged Ticket makes sense and is well defined, ready to be worked on 2 - pick next If looking for work, pick this ticket :-) labels Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Ticket makes sense and is well defined, ready to be worked on 2 - pick next If looking for work, pick this ticket :-) help wanted Great tickets to get started contributing!
Projects
None yet
Development

No branches or pull requests

1 participant