Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWIMNIO: the startMonitoring / initial contact points should get a max nr of attempts #32

Open
ktoso opened this issue Aug 22, 2020 · 1 comment
Open

SWIMNIO: the startMonitoring / initial contact points should get a max nr of attempts #32

ktoso opened this issue Aug 22, 2020 · 1 comment
Labels
good first issue Good first issue to pick up if you'd like to start out contributing help wanted Extra attention is needed s:small Small task (in T-shirt sizing) t:swim

Comments

@ktoso
Copy link
Member

ktoso commented Aug 22, 2020 •
edited

Today we just try once keep trying forever to contact the initial contact points; there should be some maximum number of attempts

This should update receiveStartMonitoring(node: Node) { to make a small timer and have counts for the attempts
@ktoso ktoso added good first issue Good first issue to pick up if you'd like to start out contributing help wanted Extra attention is needed s:small Small task (in T-shirt sizing) t:swim labels Aug 22, 2020
@ktoso
Copy link
Member Author

ktoso commented Aug 24, 2020

Also improve the log statements then, e.g.

self.log.debug("Failed to initial ping, will try again (\(attempt)/\(maxAttempts) attempts made)", metadata: ["ping/target": "\(node)", "error": "\(error)"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issue to pick up if you'd like to start out contributing help wanted Extra attention is needed s:small Small task (in T-shirt sizing) t:swim
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ktoso