Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate swift-tracing into SWIM #30

Open
ktoso opened this issue Aug 22, 2020 · 1 comment
Open

Integrate swift-tracing into SWIM #30

ktoso opened this issue Aug 22, 2020 · 1 comment
Labels
1 - triaged Task makes sense, is well defined, and is ready to be worked on help wanted Extra attention is needed i:tracing
Milestone

Comments

@ktoso
Copy link
Member

ktoso commented Aug 22, 2020

It would be quite nice to optionally be able to pass around baggage context in such way that tracing will just work:

  • The Instance should return baggage context whenever it yields a send... directive
  • the Peer protocols should gain a context parameter (BaggageContext)
  • implementations should pass the context always
    • if a tracer is enabled, this will contain the trace ids so tracing "just works"

we'd small fun traces of the pings and pingReq (this one is more interesting since it performs a "hop" through a node, so that's nice to view).

We should also visualize a pingRequest as containing all of the pings this causes.

Tracing: https://github.com/slashmo/gsoc-swift-tracing

@ktoso ktoso added 1 - triaged Task makes sense, is well defined, and is ready to be worked on help wanted Extra attention is needed i:tracing labels Aug 22, 2020
@ktoso
Copy link
Member Author

ktoso commented Aug 26, 2020

Ah to be clear: this is unlikely to be running with tracing in production I think, but if we had it on/off switchable with an envelope that could be quite great.

I think it would be a great teaching and visalization tool and it's more interesting than request-response calls, esp a pingRequest can be "fun".

@ktoso ktoso added this to the x - Future milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Task makes sense, is well defined, and is ready to be worked on help wanted Extra attention is needed i:tracing
Projects
None yet
Development

No branches or pull requests

1 participant