Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the PingRequestResponseDirective #20

Open
ktoso opened this issue Aug 20, 2020 · 0 comments
Open

Cleanup the PingRequestResponseDirective #20

ktoso opened this issue Aug 20, 2020 · 0 comments
Labels
1 - triaged Task makes sense, is well defined, and is ready to be worked on 2 - pick next If looking for work, pick this ticket. It is triaged and should be picked up soon help wanted Extra attention is needed s:small Small task (in T-shirt sizing)

Comments

@ktoso
Copy link
Member

ktoso commented Aug 20, 2020

It is not easy to act on and implementations end up using default: to ignore most cases:

    public enum PingRequestResponseDirective {
        case gossipProcessed(GossipProcessedDirective)

        case alive(previousStatus: SWIM.Status) // TODO: offer a membership change option rather?
        case nackReceived
        /// Indicates that the `target` of the ping response is not known to this peer anymore,
        /// it could be that we already marked it as dead and removed it.
        ///
        /// No additional action, except optionally some debug logging should be performed.
        case unknownMember
        case newlySuspect(previousStatus: SWIM.Status, suspect: SWIM.Member)
        case alreadySuspect
        case alreadyUnreachable
        case alreadyDead
        /// The incoming gossip is older than already known information about the target peer (by incarnation), and was (safely) ignored.
        /// The current status of the peer is as returned in `currentStatus`.
        case ignoredDueToOlderStatus(currentStatus: SWIM.Status)
    }

it should rather have gossip processed and emit change? if a change is to be emitted and additional information but only informational what the status is now

@ktoso ktoso added s:small Small task (in T-shirt sizing) help wanted Extra attention is needed 1 - triaged Task makes sense, is well defined, and is ready to be worked on 2 - pick next If looking for work, pick this ticket. It is triaged and should be picked up soon labels Aug 20, 2020
@ktoso ktoso modified the milestones: 0.1.0, 0.1.1 Aug 22, 2020
@ktoso ktoso modified the milestones: 0.2.0, 0.3.0 Sep 8, 2020
@ktoso ktoso modified the milestones: 0.3.0, 0.4.0 Oct 2, 2020
@ktoso ktoso removed this from the 0.4.0 milestone Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Task makes sense, is well defined, and is ready to be worked on 2 - pick next If looking for work, pick this ticket. It is triaged and should be picked up soon help wanted Extra attention is needed s:small Small task (in T-shirt sizing)
Projects
None yet
Development

No branches or pull requests

1 participant