Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWIM: Remove ack incarnation, use gossip about self instead? #11

Open
ktoso opened this issue Aug 7, 2020 · 0 comments
Open

SWIM: Remove ack incarnation, use gossip about self instead? #11

ktoso opened this issue Aug 7, 2020 · 0 comments
Labels
1 - triaged Task makes sense, is well defined, and is ready to be worked on t:swim

Comments

@ktoso
Copy link
Member

ktoso commented Aug 7, 2020

Proposal by @avolokhov


Remove incarnation from ack payload and put information about pinged instance into response payload.
This will deduplicate logic of membership dissemination code and condense it in gossip payload processing.

Motivation:

Current SWIM protocol has two ways to notify about group membership: membership about everyone except pinged instance is disseminated in gossip payload, and membership about self is stored in a dedicated incarnation field. This forces us to have essentially the same membership processing code in two places. This PR removes this duplication and makes gossip payload the only way to pass group membership information.

Modifications:

  • SWIM Ack ping response no longer contains incarnation field.
  • SWIM gossip payload will always carry information about pinged instance.
  • SWIMShell will only modify group membership information based on gossip payload

Need to consider the deeper impact of such change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Task makes sense, is well defined, and is ready to be worked on t:swim
Projects
None yet
Development

No branches or pull requests

1 participant