Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Line endings should be consistent over all files in the repository #72

Open
pfistererm opened this issue Nov 4, 2019 · 0 comments
Open
Assignees
Labels
Prio: Low New feature or request Status: Accepted Issue or PR is accepted Type: Feature Issue or PR is a new feature

Comments

@pfistererm
Copy link
Contributor

pfistererm commented Nov 4, 2019

Currently, several files have Windows-style line endings, while all files should have Unix-style line endings.

Feature request

Expected Behavior - What where you expecting to happen?

All files should have Unix-style line endings.

Current Behavior - What happens?

Inconsistent line endings over files.

Possible Solution

Convert all files with Windows line ending to Unix line endings.
However, please first merge existing pull requests, as this is a change that will merging very complicated.

We also might consider an automatic check for the correct line endings

Context

We already have much trouble because of inconsistent line endings. This is an annoying point that might demotivate contributors.

Notes and further information

I did a search with the following command on a checkout of the aposin master:
find org.aposin.licensescout.* -exec file {} ; | grep CRLF
I found 157 matching files.

@pfistererm pfistererm added Type: Feature Issue or PR is a new feature Status: Pending Issue or PR awaits response Prio: Triage Triage Priority labels Nov 4, 2019
@aposin-bot aposin-bot added Prio: Low New feature or request Status: Accepted Issue or PR is accepted and removed Prio: Triage Triage Priority Status: Pending Issue or PR awaits response labels Dec 2, 2019
@pfistererm pfistererm mentioned this issue Feb 19, 2020
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Prio: Low New feature or request Status: Accepted Issue or PR is accepted Type: Feature Issue or PR is a new feature
Development

No branches or pull requests

2 participants