Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency in opentelemetry-proto version #4973

Open
Geal opened this issue Apr 17, 2024 · 2 comments
Open

inconsistency in opentelemetry-proto version #4973

Geal opened this issue Apr 17, 2024 · 2 comments

Comments

@Geal
Copy link
Contributor

Geal commented Apr 17, 2024

Most of the router uses the opentelemetry-proto version at version 0.3 through transitive dependencies, but #4842 introduced opentelemetry-proto at version 0.5 as a direct dependency, which means we now have inconsistent dependency trees in different parts of our telemetry:

$ cargo tree -i opentelemetry_sdk@0.22.1
opentelemetry_sdk v0.22.1
└── opentelemetry-proto v0.5.0
    [dev-dependencies]
    └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)

$ cargo tree -i opentelemetry_sdk@0.20.0
opentelemetry_sdk v0.20.0
├── opentelemetry v0.20.0
│   ├── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
│   ├── opentelemetry-datadog v0.8.0
│   │   └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
│   ├── opentelemetry-jaeger v0.19.0
│   │   └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
│   ├── opentelemetry-semantic-conventions v0.12.0
│   │   ├── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
│   │   ├── opentelemetry-datadog v0.8.0 (*)
│   │   ├── opentelemetry-jaeger v0.19.0 (*)
│   │   ├── opentelemetry-otlp v0.13.0
│   │   │   └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
│   │   └── opentelemetry-zipkin v0.18.0
│   │       └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
│   ├── opentelemetry-zipkin v0.18.0 (*)
│   └── tracing-opentelemetry v0.21.0
│       └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
│   [dev-dependencies]
│   └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
├── opentelemetry-otlp v0.13.0 (*)
├── opentelemetry-prometheus v0.13.0
│   └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
├── opentelemetry-proto v0.3.0
│   └── opentelemetry-otlp v0.13.0 (*)
├── opentelemetry-stdout v0.1.0
│   [dev-dependencies]
│   └── apollo-router v1.45.0-alpha.1 (/home/geal/dev/router/apollo-router)
└── tracing-opentelemetry v0.21.0 (*)

Have we checked that this will not cause issues? @BrynCooke ?

@abernix
Copy link
Member

abernix commented May 6, 2024

How important is this to jump on?

@BrynCooke
Copy link
Contributor

BrynCooke commented May 6, 2024

It's in the [dev-dependencies] to allow us to test otel payloads. I don't think it's an issue unless there is some way that dev dependencies can affect the main build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants