Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global rate limiting error messages being incorrectly returned #4943

Open
lleadbet opened this issue Apr 11, 2024 · 0 comments
Open

Global rate limiting error messages being incorrectly returned #4943

lleadbet opened this issue Apr 11, 2024 · 0 comments
Labels

Comments

@lleadbet
Copy link
Contributor

Describe the bug

When using the global_rate_limit feature under router (see example config), the router returns:

{
  "error": {
    "message": "Unexpected token 'y', \"your reque\"... is not valid JSON",
    "stack": "SyntaxError: Unexpected token 'y', \"your reque\"... is not valid JSON"
  }
}

To Reproduce

With config having:

traffic_shaping:
  router:
    global_rate_limit:
      capacity: 1
      interval: 1s

And sending a number of requests in a row, you'll see the above issue.

Expected behavior

The error to be correctly shown.

Desktop (please complete the following information):

  • OS: macOS
  • Version v1.43.2
@Geal Geal added the good first issue Good for newcomers label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants