Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Remove puppeteer dependencies #160

Open
Troy-Yang opened this issue Nov 6, 2020 · 3 comments
Open

Remove puppeteer dependencies #160

Troy-Yang opened this issue Nov 6, 2020 · 3 comments

Comments

@Troy-Yang
Copy link

Hi,

I found two plugins gatsby-remark-mermaid and gatsby-plugin-printer depends on puppeteer which will download chrome instance during installing.

More importantly, it will throw an error and result to building failed durring gitlab pipeline.
`
error "gatsby-plugin-printer" threw an error while running the onPostBuild lifecycle:
Failed to launch chrome!
/builds/xxxx/node_modules/puppeteer/.local-chromium/linux-686378/chrome-linux/chrome: error while loading shared libraries: libX11-xcb.so.1: cannot open shared object file: No such file or directory

Error: Failed to launch chrome!
/builds/xxx/node_modules/puppeteer/.local-chromium/linux-686 378/chrome-linux/chrome: error while loading shared libraries: libX11-xcb.so.1 : cannot open shared object file: No such file or directory
`

I am thinking whether we can remove such plugins or override to remove them?

Thanks

@trevorblades
Copy link
Contributor

This is a fair request. Currently, the Apollo docs depend on printer to create our social sharing cards, but I've been planning on changing this to use Cloudinary instead. Once that change is made, we'll be able to drop gatsby-plugin-printer.

I think it's reasonable for us to selectively install gatsby-plugin-mermaid on docs websites that actually use it, rather than including it in this theme. I'll work on making these changes and update this issue when I have more information.

@Troy-Yang
Copy link
Author

Thanks man, Looking forward!

@Carlosf96
Copy link

any updates ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants