You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Hello,
not a real issue but just a naming of a method that confused me for a bit.
In datasource/launch there is method called launchReducer passed to Array.map. This method is responsible to take each launch returned by the Rest API and mapping it to another object.
So I guess this function should be called lauchMapper, because that's what it does. It doesn't reduce multiple element into a single one, isn't it?
Just highlighting this because it is a bit confusing
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hello,
not a real issue but just a naming of a method that confused me for a bit.
In datasource/launch there is method called
launchReducer
passed toArray.map
. This method is responsible to take each launch returned by the Rest API and mapping it to another object.So I guess this function should be called
lauchMapper
, because that's what it does. It doesn't reduce multiple element into a single one, isn't it?Just highlighting this because it is a bit confusing
The text was updated successfully, but these errors were encountered: