credentials option not working in apollo-link-batch-http

[Morantron]

Intended outcome: credentials option should work when using apollo-link-batch-http. If graphql is behind basic http auth for example, credentials: "same-origin" should propagate credentials.

Actual outcome: Credentials are not being propagate, getting a HTTP 401 response code.

How to reproduce the issue:

See repo https://github.com/Morantron/apollo-link-batch-http-credentials-bug

[evans]

We just published a new version of apollo-link-batch-http. Can you confirm the issue is still present?

[Morantron]

Awesome! It's fixed now on 1.1.0 version, thanks! 🎉 🙌

[mshwery]

This issue is still occurring (or had a regression) in apollo-link-batch-http@1.2.1. Using configuration according to the docs:

  new BatchHttpLink({
    uri,
    credentials: 'same-origin',
    headers: {
      accept: 'application/json'
    }
  })

Neither the credentials value nor the headers object are respected.