Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add option to customize Body serialization #96

Closed
paulpdaniels opened this issue Mar 27, 2018 · 2 comments · Fixed by #103
Closed

Feature: Add option to customize Body serialization #96

paulpdaniels opened this issue Mar 27, 2018 · 2 comments · Fixed by #103
Labels
feature Feature: new addition or enhancement to existing solutions
Milestone
v0.3.0

Comments

@paulpdaniels
Copy link
Contributor

So I noticed that here rest-link seems to be automatically assuming the body is json and serializing it as such. It would be nice if that were configurable so that I could instead pass in a multipart/form-data.

I'd be willing to PR it, I think the easiest way would be to just mimic how bodyBuilder is created and have another option called bodySerializer that defaults to JSON.
@ghost ghost added the feature Feature: new addition or enhancement to existing solutions label Mar 27, 2018
@paulpdaniels paulpdaniels changed the title Add option to customer Body serialization Feature: Add option to customer Body serialization Mar 27, 2018
@ghost ghost added the feature Feature: new addition or enhancement to existing solutions label Mar 27, 2018
@fbartho
Copy link
Collaborator

fbartho commented Apr 25, 2018

This is a great idea, I'd support this feature being added. I'd be happy to help review a PR that does this.

@fbartho fbartho changed the title Feature: Add option to customer Body serialization Feature: Add option to customize Body serialization Apr 25, 2018
@ghost ghost added the feature Feature: new addition or enhancement to existing solutions label Apr 25, 2018
@paulpdaniels paulpdaniels mentioned this issue Apr 26, 2018
Merged
@isopterix
Copy link

I think this is possibly related to my new issue #107 .

@marnusw marnusw mentioned this issue May 11, 2018
Closed
@fbartho fbartho added this to the v0.3.0 milestone May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature: new addition or enhancement to existing solutions
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Feat: Add custom body serializer support paulpdaniels/apollo-link-rest
3 participants
@fbartho @paulpdaniels @isopterix