Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacyResponse and prepare for partial/incremental caching #3370

Closed
calvincestari opened this issue Apr 17, 2024 · 2 comments
Closed
Assignees

Comments

@calvincestari
Copy link
Member

The cacheWriteInterceptor currently relies on doing an inefficient double-parsing of the received response to get the cache records for a cache write. This is incompatible with partial and incremental responses. Instead we should capture the cache records during the first response parsing and store them for the CacheWriteInterceptor to use later in the chain.

@calvincestari
Copy link
Member Author

Closing this as it was completed with the merging of apollographql/apollo-ios-dev#337.

Copy link

github-actions bot commented May 8, 2024

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant