Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hasDeferredFragments property and associated logic #3277

Closed
Tracked by #3093
calvincestari opened this issue Nov 6, 2023 · 2 comments · Fixed by apollographql/apollo-ios-dev#217
Closed
Tracked by #3093
Assignees
Labels
codegen Issues related to or arising from code generation

Comments

@calvincestari
Copy link
Member

calvincestari commented Nov 6, 2023

For context, at the time of creating this issue, hasDeferredFragment is used to alter the accept header of the request when it is an operation that uses the @defer directive. In standardizing the HTTP headers sent by the Apollo clients we may just be able to send the multipart/mixed part of the accept header with all query and mutation operations regardless of whether they use @defer or not. If that's done then there will be no value to the hasDeferredFragment property.

Note that this is before the executor and caching layers of the defer work are complete so it's possible the hasDeferredFragment property proves necessary for those to function correctly. So..TBD.

@calvincestari
Copy link
Member Author

In standardizing the HTTP headers sent by the Apollo clients we may just be able to send the multipart/mixed part of the accept header with all query and mutation operations regardless of whether they use @defer or not. If that's done then there will be no value to the hasDeferredFragment property.

I'm closing this issue because this is the current state of behaviour in the feature/defer-execution-networking branch.

Copy link

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen Issues related to or arising from code generation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant