Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to generator to output JavaScript instead of TypeScript #77

Open
bennypowers opened this issue Sep 30, 2020 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed PRs Welcome We welcome contributions

Comments

@bennypowers
Copy link
Member

The generator currently outputs TypeScript projects only. It should have an option to output JavaScript projects.

This could be accomplished without duplicating code by the following steps

  1. If the TypeScript option is selected, continue as normal
  2. If the JavaScript option is selected, run all the same steps as the TypeScript generator, but add the following steps afterwards:
    1. Run esbuild or TSC on the outputted TypeScript sources (minify: false)
    2. If necessary, run eslint --fix to align with linting standards
    3. Delete the generated TypeScript sources.

The generator should detect if the user is trying to add a JS component to a TS project and vice-versa, and either error out or warn.

Bonus points to adding unit and integration tests to the generator.

@bennypowers bennypowers added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed PRs Welcome We welcome contributions hacktoberfest labels Sep 30, 2020
@shikhar13012001
Copy link

I want to work on this issue can you please assign this to me @bennypowers ?

@bennypowers
Copy link
Member Author

go ahead submit the PR, i'll review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed PRs Welcome We welcome contributions
Projects
None yet
Development

No branches or pull requests

2 participants