Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with nodenext #282

Open
LasseRosenow opened this issue Apr 4, 2023 · 1 comment
Open

Incompatible with nodenext #282

LasseRosenow opened this issue Apr 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@LasseRosenow
Copy link

LasseRosenow commented Apr 4, 2023

Package

@apollo-elements/core

Description

When setting the moduleResolution on tsconfig to nodenext causes Apollo Elements not to work anymore.
The type inference is totally broken and the query.data field defaults to unknown.

This is caused by the following problem:

Interface 'ApolloQueryControllerOptions<D, V>' cannot simultaneously extend types 'ApolloControllerOptions<D, V>' and 'Partial<WatchQueryOptions<Variables<D, V>, Data<D>>>'. Named property 'context' of types 'ApolloControllerOptions<D, V>' and 'Partial<WatchQueryOptions<Variables<D, V>, Data<D>>>' are not identical.ts(2320)

Expected Behavior

It should also work fine in nodenext

Version

2.1.2

@LasseRosenow LasseRosenow added the bug Something isn't working label Apr 4, 2023
@bennypowers
Copy link
Member

#278 or something like it might one day fix this. Unfortunately it does appear that there may have been breaking changes to apollo's rather gnarly internal types in a minor release, or at least that ts 4.9 broke the existing types. If you'd like to take a stab at this i'd be happy to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants