Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): default to notifyOnNetworkStatusChange #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bennypowers
Copy link
Member

fixes #248

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: 9c47d0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo-elements/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for apollo-elements ready!

Name Link
🔨 Latest commit 8ea9362
🔍 Latest deploy log https://app.netlify.com/sites/apollo-elements/deploys/6478b70290934f00084365f8
😎 Deploy Preview https://deploy-preview-287--apollo-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for apollo-elements ready!

Name Link
🔨 Latest commit 9c47d0d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-elements/deploys/6478b7417cef560008873e16
😎 Deploy Preview https://deploy-preview-287--apollo-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loading property doesn't change with autosubscribe and no explicit notifyOnNetworkStatusChange: true
1 participant