Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change context menu to open selected file and watch file for changes. #7

Closed
wants to merge 8 commits into from

Conversation

johnwebbcole
Copy link

added .eslint.js file matching the .editorconfig file.

Refactored toggle and changed the context menu items to launch
a preview window with a file watcher. The context menus also
open the selected file instead of calling toggle on the active
TextEditor. This fixes #6 and allows you to watch a file that is
a combined .jscad file.

removed some eslint errors.

I didn't see how you were running the unit tests.

Refactored `toggle` and changed the context menu items to launch
a preview window with a file watcher.  The context menus also
open the selected file instead of calling `toggle` on the active
`TextEditor`.

removed some eslint errors.
@apla
Copy link
Owner

apla commented Jan 1, 2017

This patch is a mess. Please rewrite it. If you want to add file watcher, just add a file watcher in one pull request.

@apla apla closed this Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external file changes do not cause reload
2 participants