Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vert.x Basic Authentication JDBC - Driver missing and pooling problems #2569

Open
volkflo opened this issue Jul 19, 2023 · 0 comments · May be fixed by #2570
Open

Vert.x Basic Authentication JDBC - Driver missing and pooling problems #2569

volkflo opened this issue Jul 19, 2023 · 0 comments · May be fixed by #2570
Labels
S: Triage T: Bug

Comments

@volkflo
Copy link
Member

volkflo commented Jul 19, 2023

Apiman Version

3.X

Apiman Manager Distro

Tomcat

Apiman Gateway Distro

Vert.x

Java Version

11

Operating System

Manjaro

Are you running Apiman in a container, or on an orchestration platform?

No (Bare Metal)

Describe the bug

Currently the bundled vert.x gatway jar does not contain any jdbc driver.
That makes the built in Basic Auth Policy with JDCB unusable.

In addition if you add the drives the implementation creates a new client for each request which leads to connection pooling problems after a while.

Expected behaviour

  • Include JDBC Driver as we do it for wildfly (can be discussed to keep size smaller)
  • Clients are cached

Actual behaviour

No response

How to Reproduce

  1. Create a public API
  2. Attach Basic Auth Policy with a JDBC source
  3. Publish API
  4. Make request with basic auth

Relevant log output

No response

Anything else?

No response
volkflo added a commit that referenced this issue Jul 19, 2023
@volkflo
fix(gateway-vertx): add jdbc driver to vert.x gateway
5db905b 
Adding the default set of apiman jdbc drivers to vert.x.
In addition cache non-shared clients (e.g. clients for basic-auth-policy) instead of creating a new once per request.

Closes: #2569
@volkflo volkflo linked a pull request Jul 19, 2023 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: Triage T: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gateway-vertx): use cache for non-shared JDBC client apiman/apiman
1 participant
@volkflo