Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use biome for code formatting #2301

Merged
merged 7 commits into from May 22, 2024
Merged

chore: use biome for code formatting #2301

merged 7 commits into from May 22, 2024

Conversation

janbuchar
Copy link
Contributor

@janbuchar janbuchar commented Jan 24, 2024

This takes ~50ms on my machine 馃く

@github-actions github-actions bot added this to the 84th sprint - Tooling team milestone Mar 1, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鈿狅笍 Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Mar 1, 2024
biome.json Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鈿狅笍 Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鈿狅笍 Pull Request Tookit has failed!

If issue is not linked to the pull request then estimate the pull request!

@janbuchar janbuchar marked this pull request as ready for review March 1, 2024 16:07
@janbuchar
Copy link
Contributor Author

@B4nan I rebased this to current master. Shall we?

: never
// Return the result
: Result;
> = Input extends readonly [infer FirstValue, ...infer Rest] | [infer FirstValue, ...infer Rest] // If the input is a tuple or a readonly array (`[] as const`), get the first and the rest of the values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bless their soul, they have the new ternaries from prettier (or just more readable ternaries)

Not the biggest fan that it moved comments around but shrug, its fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also disable the formatter in such places

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @vladfrangu says it's fine, it's fine. Can I leave it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these comments of mine aren't blockers in any way, just things I wanted to call out :D

packages/cli/src/index.ts Outdated Show resolved Hide resolved
biome.json Show resolved Hide resolved
@B4nan B4nan merged commit 5db533a into master May 22, 2024
9 checks passed
@B4nan B4nan deleted the biome branch May 22, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt a code formatter and enforce it with CI
4 participants