Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt a code formatter and enforce it with CI #2366

Closed
janbuchar opened this issue Feb 26, 2024 · 0 comments · Fixed by #2301
Closed

Adopt a code formatter and enforce it with CI #2366

janbuchar opened this issue Feb 26, 2024 · 0 comments · Fixed by #2301
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Contributor

Looks like biome is the winner. @B4nan could you fill some details about the necessary eslint setup you mentioned?
@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 26, 2024
@janbuchar janbuchar mentioned this issue Mar 1, 2024
Merged
B4nan pushed a commit that referenced this issue May 22, 2024
@janbuchar
chore: use biome for code formatting (#2301)
5db533a 
This takes ~50ms on my machine 🤯 

- closes #2366 
- Replacing spaces with tabs won't be done right here, right now.
- eslint and biome are reconciled
- ~biome check fails because of typescript errors - we can either fix
those or find a way to ignore it~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use biome for code formatting apify/crawlee
1 participant
@janbuchar