Repository delete() ModelNotFoundException is never thrown

[m0nclous]

Apiato Version

12.4.1

PHP Version

8.3

Database Driver & Version

No response

Description

Exception ModelNotFoundException is never thrown in this method, but the phpdoc says it can be thrown.

apiato/app/Ship/Parents/Repositories/Repository.php

Lines 58 to 73 in 46b8001

	/**
	* Delete a model by its primary key or throw an exception.
	*
	* @param int|string $id
	*
	* @throws ModelNotFoundException
	* @throws DeleteResourceFailedException
	*/
	public function delete($id): bool
	{
	try {
	return (bool) parent::delete($id);
	} catch (\Exception) {
	throw new DeleteResourceFailedException();
	}
	}

Maybe it makes sense to catch ModelNotFoundException and in this case return false from the delete function (similar to other methods that return empty data)?

Or catch ModelNotFoundException and throw NotFoundException to indicate that the requested model is not available for deletion.

apiato/app/Ship/Exceptions/NotFoundException.php

Lines 3 to 12 in 46b8001

	namespace App\Ship\Exceptions;
	use App\Ship\Parents\Exceptions\Exception;
	use Symfony\Component\HttpFoundation\Response;
	class NotFoundException extends Exception
	{
	protected $code = Response::HTTP_NOT_FOUND;
	protected $message = 'The requested resource could not be found.';
	}

Steps To Reproduce

app(UserRepository::class)->delete(9999999);