Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow More Custom Tags #67

Open
aterris opened this issue Feb 15, 2018 · 2 comments
Open

Allow More Custom Tags #67

aterris opened this issue Feb 15, 2018 · 2 comments

Comments

@aterris
Copy link

aterris commented Feb 15, 2018

Looking through the code I noticed that you have limited custom tags in b6868b1

I ran into this as I was trying to add some custom tags to some of my custom metrics. I was wondering if you could shed any light on the context behind that change?

I was thinking about doing one of the following...

  1. Updating docs to reflect that
  2. Remove the constraint entirely
  3. Enable setting allowed custom tags via environment variable

Before I made a PR, I wanted to understand why you made that change in the first place.

@w-vi
Copy link
Member

w-vi commented Feb 15, 2018

Yes they are limited because datadog does not handle very well if you have loads of them. This list should actually be configurable but apparently this has never happened. I this having the list defined by environment variable is a good approach so if you have a PR ready then please go ahead.

@aterris
Copy link
Author

aterris commented Feb 15, 2018

Not quite ready but should be able to create one soon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants