Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Specify backup/restore PORT by name #7229

Open
shanshanying opened this issue May 1, 2024 · 2 comments
Open

[Improvement] Specify backup/restore PORT by name #7229

shanshanying opened this issue May 1, 2024 · 2 comments
Assignees
Labels
area/data-protection good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request

Comments

@shanshanying
Copy link
Contributor

Descriptions

When a backup job is created, some built-in ENVs will be injected into the backup JOB to perform a BACKUP task. Such envs are not not limited to:

- name: DP_DB_HOST
  value: mycluster-mysql-comp-0.mycluster-mysql-comp-headless
- name: DP_DB_PORT
  value: "3306"

The full list of ENVs can be found in :

These ENVs are inferred from target cluster (say on which cluster to do backup).
e.g.

  • DP_DB_HOST is inferred from target instance
  • DP_DB_PORT is inferred from contaienrs[0].ports[0], if not specified.

Since release 0.9, ConnectionCredential is deprecated. we'd better as as useer to

  1. explicitly specifiy the PROT
  2. specify by either port number of port name (there are cases PORT Nubmer is not fixed, e.g. svc.spec.ports[].targePort is of type 'intorstring')
@shanshanying shanshanying added kind/enhancement New feature or request good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 1, 2024
@YTGhost
Copy link

YTGhost commented May 6, 2024

Hi, I'm interested in this issue. Please assign it to me. Thanks.

@YTGhost
Copy link

YTGhost commented May 21, 2024

@shanshanying Hi, I am trying to solve this issue, but I still have some unclear points about it, such as where should the user specify the PORT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-protection good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants