Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Problem] Windows Conda Build Does Not Support C++20 Features #16720

Open
zxybazh opened this issue Mar 14, 2024 · 3 comments
Open

[CI Problem] Windows Conda Build Does Not Support C++20 Features #16720

zxybazh opened this issue Mar 14, 2024 · 3 comments
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure

Comments

@zxybazh
Copy link
Member

zxybazh commented Mar 14, 2024

The windows conda build would fail because it doesn't support c++20 feature such as designated initializer.

Branch/PR Failing

a5bbfcc

Jenkins Link

Provide a link to the specific run that has failed.

Flakiness

Reproduces in the same PR for different commits.

Triage

Please refer to the list of label tags here to find the relevant tags and add them below in a bullet format (example below).

  • needs-triage
@zxybazh zxybazh added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure labels Mar 14, 2024
@tqchen
Copy link
Member

tqchen commented Mar 15, 2024

Can we first update to make it cxx17 compatible?

@vinx13
Copy link
Member

vinx13 commented Mar 15, 2024

we are still using c++17, the error is because c++20 is not enabled

@zxybazh
Copy link
Member Author

zxybazh commented Mar 15, 2024

Original PR #16717 has been updated to make it c++17 compatible and passed the CI. This issue is created to mark that c++20 features may cause windows CI to fail during conda build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type:ci Relates to TVM CI infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants