Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add URLParser for Derby/Sybase/SQLite/DB2/OceanBase #12207

Closed
3 tasks done
CzyerChen opened this issue May 10, 2024 · 4 comments
Closed
3 tasks done

[Feature] Add URLParser for Derby/Sybase/SQLite/DB2/OceanBase #12207

CzyerChen opened this issue May 10, 2024 · 4 comments
Assignees
Labels
agent Language agent related. feature New feature java Java agent related
Milestone

Comments

@CzyerChen
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

current DB types in URLParser :

  • MYSQL
  • ORACLE
  • H2
  • POSTGRESQL
  • MARIADB
  • MSSQL
  • KYLIN
  • IMPALA
  • CLICKHOUSE

I want to add URL parsing types:

  • Derby
  • Sybase
  • SQLite
  • DB2
  • OceanBase

Use case

When the database connection pool connecting to Derby/Sybase/SQLite/DB2/OceanBase, JDBC URL can be parsed and the monitoring meters can be reported.

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@CzyerChen CzyerChen added the feature New feature label May 10, 2024
@CzyerChen CzyerChen changed the title [Bug] Add URLParser for Derby/Sybase/SQLite/DB2/OceanBase [Feature] Add URLParser for Derby/Sybase/SQLite/DB2/OceanBase May 10, 2024
@wu-sheng
Copy link
Member

Can we make sure the only gap for tracing these databases JDBC access are about this?
Because AFAIK, if we don't add instrument for driver explicitly, the connection info is still missing.

@wu-sheng wu-sheng added agent Language agent related. java Java agent related labels May 10, 2024
@wu-sheng wu-sheng added this to the Java - 9.3.0 milestone May 10, 2024
@CzyerChen
Copy link
Contributor Author

Can we make sure the only gap for tracing these databases JDBC access are about this?
Because AFAIK, if we don't add instrument for driver explicitly, the connection info is still missing.

None of these databases have plugins to track SQL statements now, and adding these URLParsers can make connection pools report pool metrics of these databases successfully.
image

Meanwhile, for database connection pools like druid/c3p0, it is necessary to optimized the part on obtaining ConnectionInfo of the database that have not yet implemented monitoring to avoid NPE.

@wu-sheng
Copy link
Member

None of these databases have plugins to track SQL statements now, and adding these URLParsers can make connection pools report pool metrics of these databases successfully.

So, this is for meter plugin enhancement. Please update docs here as well, https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/supported-list/#meter-plugins, to list all supported database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. feature New feature java Java agent related
Projects
None yet
Development

No branches or pull requests

2 participants