Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8084] fix typo #8085

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #8084] fix typo #8085

wants to merge 2 commits into from

Conversation

hakusai22
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #issue_id

Brief Description

fix doc and code typo

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.09091% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 42.82%. Comparing base (af43a3e) to head (fd11848).

Files Patch % Lines
...mq/broker/topic/TopicQueueMappingCleanService.java 0.00% 8 Missing ⚠️
...mq/client/impl/producer/DefaultMQProducerImpl.java 57.14% 2 Missing and 4 partials ⚠️
...ocketmq/broker/processor/PullMessageProcessor.java 0.00% 3 Missing ⚠️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 0.00% 2 Missing ⚠️
...g/apache/rocketmq/common/filter/impl/Operator.java 0.00% 2 Missing ⚠️
...mq/remoting/protocol/body/PopProcessQueueInfo.java 0.00% 2 Missing ⚠️
...n/java/org/apache/rocketmq/test/util/FileUtil.java 0.00% 2 Missing ⚠️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 0.00% 1 Missing ⚠️
...rocketmq/client/impl/consumer/PopProcessQueue.java 0.00% 1 Missing ⚠️
...apache/rocketmq/common/filter/impl/PolishExpr.java 0.00% 1 Missing ⚠️
... and 11 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #8085      +/-   ##
=============================================
- Coverage      42.84%   42.82%   -0.03%     
+ Complexity     10349    10341       -8     
=============================================
  Files           1270     1270              
  Lines          88681    88681              
  Branches       11397    11397              
=============================================
- Hits           37995    37977      -18     
- Misses         45990    46004      +14     
- Partials        4696     4700       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HScarb
HScarb previously approved these changes May 6, 2024
View reviewed changes
RongtongJin
RongtongJin previously approved these changes May 22, 2024
View reviewed changes
@RongtongJin
Copy link
Contributor

Hi @hakusai22 , Could you help resolve the conflict？

@hakusai22
Merge branch 'develop' into fix_typo_v2
e7d4545 
# Conflicts:
#	client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@hakusai22 hakusai22 dismissed stale reviews from RongtongJin and HScarb via e7d4545 May 22, 2024 01:11
@hakusai22
Copy link
Contributor Author

hakusai22 commented May 22, 2024 •
edited

Hi @hakusai22 , Could you help resolve the conflict？

does

Hi @hakusai22 , Could you help resolve the conflict？

done . Why? The bug I found was merged in by others in advance #8091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humkum humkum humkum approved these changes

@HScarb HScarb HScarb left review comments

@RongtongJin RongtongJin RongtongJin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc] Documentation Related
5 participants
@hakusai22 @codecov-commenter @RongtongJin @HScarb @humkum