Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Virtual thread support in DefaultMQPushConsumerImpl #8073

Open
1 task done
He-Pin opened this issue Apr 27, 2024 · 0 comments · May be fixed by #8072
Open
1 task done

[Enhancement] Virtual thread support in DefaultMQPushConsumerImpl #8073

He-Pin opened this issue Apr 27, 2024 · 0 comments · May be fixed by #8072
Labels
type/enhancement

Comments

@He-Pin
Copy link
Member

He-Pin commented Apr 27, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

The current DefaultMQPushConsumerImpl will pin the Carrier thread when start() and shutdown()

image

Motivation

Better Virtual thread support

Describe the Solution You'd Like

Make use of ReentrantLock instead

Describe Alternatives You've Considered

do nothing

Additional Context

No response
@He-Pin He-Pin changed the title [Enhancement] Enhancement title [Enhancement] Virtual thread support in DefaultMQPushConsumerImpl Apr 27, 2024
@He-Pin He-Pin linked a pull request Apr 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Don't ping Carrier thread when start or stop in DefaultMQPushC… He-Pin/rocketmq
1 participant
@He-Pin