[ISSUE #8055]remove unnecessary math.abs() method #8056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humkum
approved these changes
Apr 24, 2024
lizhimins
requested changes
Apr 29, 2024
| @@ -83,7 +83,7 @@ private MessageQueue selectOneMessageQueue(List<MessageQueue> messageQueueList, | |||
|
|
|||
| if (filter != null && filter.length != 0) { | |||
| for (int i = 0; i < messageQueueList.size(); i++) { | |||
| int index = Math.abs(sendQueue.incrementAndGet() % messageQueueList.size()); | |||
| int index = sendQueue.incrementAndGet() % messageQueueList.size(); | |||
There was a problem hiding this comment.
这是个 thread local int，用完会再从 0 开始，不能去掉吧
There was a problem hiding this comment.
我理解的是即使是0，做取模操作后的值也会是非负的，不需要再math.abs取绝对值吧
There was a problem hiding this comment.
这是一个线程local int，用完会再从0开始，不能去掉吧
在同一个类里，也看到了去掉math.abs的用法，应该是确定可以去掉吧，不然下面的方法就会出bug了
|
@lizhimins Please cr again. thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unnecessary math.abs() method in TopicPublishInfo#selectOneMessageQueue
Fixes #8055
remove unnecessary math.abs() method in TopicPublishInfo#selectOneMessageQueue
How Did You Test This Change?
In the ThreadLocalIndexTest class, there are already some test that the return value of the incrementAndGet method must be a positive number.