[ISSUE #8025] fix: fix topic route when topic deleted #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
requested changes
Apr 18, 2024
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8027 +/- ##
=============================================
- Coverage 42.82% 42.80% -0.02%
- Complexity 10345 10350 +5
=============================================
Files 1270 1270
Lines 88677 88678 +1
Branches 11398 11398
=============================================
- Hits 37973 37961 -12
- Misses 46004 46017 +13
Partials 4700 4700 ☔ View full report in Codecov by Sentry. |
cserwen
reviewed
May 8, 2024
| @@ -2007,6 +2007,7 @@ public TopicRouteData getTopicRouteInfoFromNameServer(final String topic, final | |||
| case ResponseCode.TOPIC_NOT_EXIST: { | |||
| if (allowTopicNotExist) { | |||
| log.warn("get Topic [{}] RouteInfoFromNameServer is not exist value", topic); | |||
| return null; | |||
There was a problem hiding this comment.
This may cause some npe, maybe need to check, such as
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8025
Brief Description
getTopicRouteInfoFromNameServerreturn null when the topic not exist and allow the topic not existtopicRouteTablewhen topic is nullHow Did You Test This Change?
UT