Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add some info log in transactional messsage check #8001

Open
1 task done
wangjiao01 opened this issue Apr 3, 2024 · 0 comments · May be fixed by #8002
Open
1 task done

[Enhancement] Add some info log in transactional messsage check #8001

wangjiao01 opened this issue Apr 3, 2024 · 0 comments · May be fixed by #8002
Labels
type/enhancement

Comments

@wangjiao01
Copy link

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

In order to know explicitly what trigger the transactional message check method, I want to add some info log in org.apache.rocketmq.broker.transaction.queue.TransactionalMessageServiceImpl#check method.

Motivation

In broker version 4.3.2, I encounter a problem that transactional message will execute checkLocalTransaction method, even I return LocalTransactionState.COMMIT_MESSAGE in executeLocalTransaction method, but there is no log info

Describe the Solution You'd Like

add some log info for three boolean variable in check method.

Describe Alternatives You've Considered

add some log info for three boolean variable in check method.

Additional Context

No response
wangjiao01 added a commit to wangjiao01/rocketmq that referenced this issue Apr 4, 2024
@wangjiao01
[apache#8001] add some info log in transactional messsage check
cbb01ff
@wangjiao01 wangjiao01 linked a pull request Apr 4, 2024 that will close this issue
Open
@wangjiao01 wangjiao01 changed the title add some info log in transactional messsage check [enhancement] Add some info log in transactional messsage check Apr 4, 2024
@wangjiao01 wangjiao01 changed the title [enhancement] Add some info log in transactional messsage check [Enhancement] Add some info log in transactional messsage check Apr 4, 2024
@wangjiao01 wangjiao01 reopened this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8001] Add some info log in transactional messsage check wangjiao01/rocketmq
1 participant
@wangjiao01