Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade kafka client #150

Closed
pjfanning opened this issue Mar 27, 2024 · 4 comments
Closed

upgrade kafka client #150

pjfanning opened this issue Mar 27, 2024 · 4 comments
Milestone

Comments

@pjfanning
Copy link
Contributor

This is constrained by a Confluent lib that we use.
https://github.com/apache/pekko-connectors-kafka/blob/main/project/Versions.scala#L40

That lib has dependencies on a 'provided' version of the kafka client that is a Confluent release, not the Apache one.

@mdedetrich I believe that you are a Kafka contributor. Do you have any thoughts on how we should approach this?

@pjfanning pjfanning added this to the 1.1.0 milestone Mar 27, 2024
@pjfanning
Copy link
Contributor Author

@mdedetrich I think we need to address this before we really consider using scala steward

@mdedetrich
Copy link
Contributor

I'll check this tomorrow, thanks for noticing

@mdedetrich
Copy link
Contributor

mdedetrich commented Apr 11, 2024

@pjfanning So this library is not a kafka library, its a serializer and even though its from Confluent its license is Apache based https://mvnrepository.com/artifact/io.confluent/kafka-avro-serializer/7.6.0 .

There shouldn't be any issue here, and its common for users of Kafka to use this library as it provides avro based serdes for kafka messages

@pjfanning
Copy link
Contributor Author

ok - it was feasible to merge all the Scala Steward PRs - a few required some minor additional changes - but all is well

My main issues with the Confluent project boil down to its non-standard maven repo and its weird in-house forks of the Apache Kafka libs. Nothing has assuaged this for me yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants