Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'newt info' should prefer tagged versions instead of master #526

Open
sjanc opened this issue Aug 17, 2023 · 1 comment
Open

'newt info' should prefer tagged versions instead of master #526

sjanc opened this issue Aug 17, 2023 · 1 comment

Comments

@sjanc
Copy link
Contributor

sjanc commented Aug 17, 2023

newt info should prefer "latest" release version instead of ones that match master branch.
Below is newt info for 1.11 release where release tags are stil matching tip of master branches.

I'd expect core and nimble be shown and 1.11.0 and 1.6.0 instead of 0.0.0

[janc@ix test]$ newt info
Apache Newt 1.11.0 / 2215fc6 / 2023-08-11_11:31
Repository info:
* apache-mynewt-core: 6de871dfa7306a06df4219470205af69c569c0d9, 0.0.1
* apache-mynewt-mcumgr: 1c9b642fa3bfb3048b7ed7e75a278667230816c2, 0.4.0
* apache-mynewt-nimble: df0718d7eacf414b2f4ed1e28f866250d92cadcb, 0.0.0
* mcuboot: 23d28832f02dcdc18687782c6cd8ba99e9b274d2, 1.10.0

@sjanc
Copy link
Contributor Author

sjanc commented Sep 7, 2023

OK, so this seems to work OK when final tags (without _rc1) are in place

[janc@ix test]$ newt info
Apache Newt 1.11.0 / 2215fc6 / 2023-08-11_11:31
Repository info:
* apache-mynewt-core: 6de871dfa7306a06df4219470205af69c569c0d9, 1.11.0
* apache-mynewt-mcumgr: 1c9b642fa3bfb3048b7ed7e75a278667230816c2, 0.4.0
* apache-mynewt-nimble: df0718d7eacf414b2f4ed1e28f866250d92cadcb, 1.6.0
* mcuboot: 23d28832f02dcdc18687782c6cd8ba99e9b274d2, 1.10.0

But 'newt new test' shows rc tags even if final tag is present.
n[janc@ix ttt]$ newt new test
Downloading project skeleton from apache/mynewt-blinky...
Downloading repository mynewt-blinky (commit: master) from https://github.com/apache/mynewt-blinky.git
Installing skeleton in test (commit: mynewt_1_11_0_rc1_tag)
Project test successfully created.

m-gorecki added a commit to m-gorecki/mynewt-newt that referenced this issue Oct 20, 2023
sjanc pushed a commit that referenced this issue Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant