Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nullable annotations #124

Open
FreeAndNil opened this issue Mar 13, 2024 · 0 comments
Open

Add support for nullable annotations #124

FreeAndNil opened this issue Mar 13, 2024 · 0 comments
Milestone
3.0.0

Comments

@FreeAndNil
Copy link
Contributor

FreeAndNil commented Mar 13, 2024 •
edited

Public classes and interfaces should get nullable annotations so that callers will be warned when passing null values.

List of breaking changes

#129 - Part 4 of nullable and modernization

  • interface log4net.Appender.AppenderCollection.IAppenderCollectionEnumerator is now obsolete and must be replaced by IEnumerator<IAppender>
  • log4net.Appender.MemoryAppender.m_eventsList (protected field) was changed from ArrayList to List<LoggingEvent>
    • for getting m_eventsList.SyncRoot you need to cast it: ((ICollection)m_eventsList).SyncRoot
@FreeAndNil FreeAndNil added this to the 3.0.0 milestone Mar 13, 2024
This was referenced Mar 13, 2024
Merged
Merged
@erikmav erikmav mentioned this issue Mar 15, 2024
Merged
FreeAndNil added a commit that referenced this issue Mar 18, 2024
@FreeAndNil
updated release notes for 3.0.0 #111, #124, #127
db44c9c
This was referenced Mar 20, 2024
Merged
Merged
This was referenced Mar 27, 2024
Merged
Merged
FreeAndNil added a commit that referenced this issue Mar 28, 2024
@FreeAndNil
#124 LoggingEvent.Level not nullable
191705e
@FreeAndNil FreeAndNil mentioned this issue Mar 28, 2024
Closed
erikmav added a commit to erikmav/logging-log4net that referenced this issue Mar 28, 2024
@erikmav
Remove obsolete properties, methods, and classes for 3.0. Add BinaryF…
6abff33 
…ormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (apache#124).
erikmav added a commit to erikmav/logging-log4net that referenced this issue Mar 28, 2024
@erikmav
Remove obsolete properties, methods, and classes for 3.0. Add BinaryF…
b4912f0 
…ormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (apache#124).
erikmav added a commit to erikmav/logging-log4net that referenced this issue Mar 28, 2024
@erikmav
Remove obsolete properties, methods, and classes for 3.0. Add BinaryF…
d1f4d9b 
…ormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (apache#124).
erikmav added a commit to erikmav/logging-log4net that referenced this issue Mar 28, 2024
@erikmav
Remove obsolete properties, methods, and classes for 3.0. Add BinaryF…
de52b66 
…ormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (apache#124).
erikmav added a commit to erikmav/logging-log4net that referenced this issue Mar 28, 2024
@erikmav
Remove obsolete properties, methods, and classes for 3.0. Add BinaryF…
106ecb5 
…ormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (apache#124).
@erikmav erikmav mentioned this issue Mar 28, 2024
Merged
FreeAndNil added a commit that referenced this issue Apr 3, 2024
@FreeAndNil
#124 restored IAppenderCollectionEnumerator
4af5332 
- added breaking changes to release notes
FreeAndNil added a commit that referenced this issue Apr 3, 2024
@FreeAndNil
#124 restored IAppenderCollectionEnumerator
7e93b50 
- implemented ICollection.Add & Remove explicitly for keeping old signatures
- added breaking changes to release notes
FreeAndNil added a commit that referenced this issue Apr 3, 2024
@FreeAndNil
#124 restored IAppenderCollectionEnumerator
6d23e81 
- implemented ICollection.Add & Remove explicitly for keeping old signatures
- added breaking changes to release notes
FreeAndNil added a commit that referenced this issue Apr 3, 2024
@FreeAndNil
#124 Dispose TextWriters in XmlLayoutTest
789190a
FreeAndNil pushed a commit that referenced this issue Apr 4, 2024
@erikmav
Remove obsolete properties, methods, and classes for 3.0 (#138)
202bb5c 
* Remove obsolete properties, methods, and classes for 3.0. Add BinaryFormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (#124).

* Seal AliasRepositoryAttribute
FreeAndNil added a commit that referenced this issue Apr 4, 2024
@FreeAndNil
#124 LoggingEvent.Level not nullable
bf9a21d
@FreeAndNil FreeAndNil mentioned this issue Apr 4, 2024
Open
FreeAndNil added a commit that referenced this issue Apr 5, 2024
@FreeAndNil
#124 fixed LoggingEventTest for execution in CE(S)T or SAST
03ed9af
FreeAndNil added a commit that referenced this issue Apr 5, 2024
@FreeAndNil
#124 added missing nullable attributes from net6-8
a8b207f
FreeAndNil added a commit that referenced this issue Apr 5, 2024
@FreeAndNil
#124 added Log4NetAssert
babde01
FreeAndNil added a commit that referenced this issue Apr 5, 2024
@FreeAndNil
#124 fixed more nullable Warnings when targeting net8.0
f0b5ad4
@FreeAndNil FreeAndNil mentioned this issue Apr 5, 2024
Merged
FreeAndNil added a commit that referenced this issue Apr 5, 2024
@FreeAndNil
#124 added links to https://github.com/dotnet/runtime
a4d877f 
- more pattern matching
FreeAndNil added a commit that referenced this issue Apr 8, 2024
@FreeAndNil
Merge pull request #141 from apache/Feature/124-nullable-net8
c4df728 
#124 fixed more nullable Warnings when targeting net8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@FreeAndNil