[INLONG-9867][Manager] Unified configuration process for standalone and sortflink #9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloyszhang
reviewed
Mar 25, 2024
.../main/java/org/apache/inlong/manager/service/resource/sort/SortStandAloneConfigOperator.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Mar 25, 2024
.../main/java/org/apache/inlong/manager/service/resource/sort/SortStandAloneConfigOperator.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Mar 25, 2024
...manager-service/src/main/java/org/apache/inlong/manager/service/core/SortClusterService.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Mar 25, 2024
...ervice/src/main/java/org/apache/inlong/manager/service/core/impl/SortClusterServiceImpl.java
Outdated
Show resolved
Hide resolved
aloyszhang
previously approved these changes
Mar 25, 2024
EMsnap
reviewed
Mar 25, 2024
...anager/manager-service/src/main/java/org/apache/inlong/manager/service/core/SortService.java
Outdated
Show resolved
Hide resolved
aloyszhang
previously approved these changes
Apr 17, 2024
aloyszhang
reviewed
Apr 23, 2024
...manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/ProcessName.java
Show resolved
Hide resolved
aloyszhang
reviewed
Apr 23, 2024
...ng-common/src/main/java/org/apache/inlong/common/pojo/sortstandalone/SortConfigResponse.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Apr 23, 2024
...nager-service/src/main/java/org/apache/inlong/manager/service/core/impl/SortServiceImpl.java
Outdated
Show resolved
Hide resolved
aloyszhang
reviewed
Apr 23, 2024
...nager-service/src/main/java/org/apache/inlong/manager/service/core/impl/SortServiceImpl.java
Outdated
Show resolved
Hide resolved
aloyszhang
previously approved these changes
Apr 23, 2024
dockerzhang
approved these changes
Apr 27, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Unified configuration process for standalone and sortflink.
The current configuration process of standalone has the following issues:
Configuration changes will be updated in real-time to the manager's cache. Once a configuration change occurs, sortstandalone will sense it and write data based on the new configuration.
Once the configuration is modified incorrectly, it can lead to issues with the entire write.
The configuration in the manager cache is to fully pull the content from the database and filter it. Each refresh requires a full database query and repeated filtering operations at the service layer.
There is no management function for whether each configuration is functioning properly. Once the configuration is registered on the manager side, it defaults to the correct configuration.
Failure to verify and issue each configuration results in unreliable configurations.
Modifications
The flowchart of standalone pull configuration is as follows:
The getClusterConfigV2 interface has been set up, where the data comes from the sort_config table, which can only be obtained through workflow configuration operations. The interface protocol is consistent with the getClusterConfig interface.
Incorporate the configuration process of sort standalone into the manager's configuration management system and add a configuration information table. The JSON format configuration information that sort standalone needs to pull will be saved in a field of this table. Only those that are successfully configured will be recorded in this table.
Modify the configuration timer to be pulled to the cache and change it to actively trigger the configuration update cache. After successful configuration, the configuration information will be registered in this configuration information table, loaded into the cache, and the md5 value will be modified.