Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TubeMQ] Adjust FATAL type error return content, without carrying class name #9613

Open
2 tasks done
gosonzhang opened this issue Jan 23, 2024 · 1 comment
Open
2 tasks done
Assignees
Labels
stage/stale Issues or PRs that had no activity for a long time type/improve

Comments

@gosonzhang
Copy link
Contributor

Description

There is indeed a problem [1] with this RPC interaction agreement: the server-side transparently transmits the exception class to the caller. In any case, the callee should return a clear error to the caller. If an unknown exception is encountered, the detailed information should be retained locally, rather than being transparently transmitted to the calling layer.

In the case where the accessed party is a malicious node injecting exceptions, there is a risk of introduction based on the aforementioned issue. This risk exists, but it is not urgent

  1. https://github.com/apache/inlong/blob/master/inlong-tubemq/tubemq-
    core/src/main/java/org/apache/inlong/tubemq/corerpc/netty/NettyClient.java#L349

InLong Component

InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@gosonzhang gosonzhang self-assigned this Jan 23, 2024
Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stage/stale Issues or PRs that had no activity for a long time label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/stale Issues or PRs that had no activity for a long time type/improve
Projects
None yet
Development

No branches or pull requests

1 participant