Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Refactor reconfigurable conf framework and apply to shuffleServer module #1711

Closed
3 tasks done
zuston opened this issue May 13, 2024 · 0 comments · Fixed by #1712
Closed
3 tasks done

[FEATURE] Refactor reconfigurable conf framework and apply to shuffleServer module #1711

zuston opened this issue May 13, 2024 · 0 comments · Fixed by #1712

Comments

@zuston
Copy link
Member

zuston commented May 13, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

#572 introduces the reconfigurable conf mechanism in coordinator side, but I don't like this implementation. This issue is to track this optimization

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zuston added a commit to zuston/incubator-uniffle that referenced this issue May 13, 2024
@zuston
[apache#1711] feat(server): introduce the reconfigurable conf
43a41dd
@zuston zuston mentioned this issue May 22, 2024
Merged
zuston added a commit that referenced this issue May 22, 2024
@zuston
[#1711] feat(server): Introduce the reconfigurable conf (#1712)
5dd4eef 
### What changes were proposed in this pull request?

Introduce the reconfigurable conf for server or other componts.

### Why are the changes needed?

Fix: #1711

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit tests.
zuston added a commit to zuston/incubator-uniffle that referenced this issue May 23, 2024
@zuston
[apache#1711][followup] fix(server): Avoid outputing too much incorre…
cb353e5 
…ct non-update logs
@zuston zuston mentioned this issue May 23, 2024
Merged
zuston added a commit to zuston/incubator-uniffle that referenced this issue May 24, 2024
@zuston
[apache#1711][FOLLOWUP] feat(coordinator): refactor the reconfigurabl…
340d1f8 
…e conf
@zuston zuston mentioned this issue May 24, 2024
Merged
zuston added a commit to zuston/incubator-uniffle that referenced this issue May 27, 2024
@zuston
[apache#1711] feat(server): Introduce the reconfigurable conf (apache…
7ef596f 
…#1712)

### What changes were proposed in this pull request?

Introduce the reconfigurable conf for server or other componts.

### Why are the changes needed?

Fix: apache#1711

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit tests.
zuston added a commit that referenced this issue May 28, 2024
@zuston
[#1711][FOLLOWUP] fix(server): Avoid outputing too much incorrect non…
59b899e 
…-update logs (#1737)

### What changes were proposed in this pull request?

Avoid outputing too much incorrect non-update logs

### Why are the changes needed?

follow up #1711

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Yes
zuston added a commit that referenced this issue May 29, 2024
@zuston
[#1711][FOLLOWUP] feat(coordinator): refactor the reconfigurable conf (…
a3a49f0 
…#1741)

### What changes were proposed in this pull request?

Refactor the reconfigurable conf for coordinator side.

### Why are the changes needed?

Follow up: #1711 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit tests
zuston added a commit to zuston/incubator-uniffle that referenced this issue May 29, 2024
@zuston
[apache#1711] feat(server): Make the health checker execution timeout…
7515313 
… reconfigurable
@zuston zuston mentioned this issue May 29, 2024
Merged
zuston added a commit that referenced this issue Jun 3, 2024
@zuston
[#1711] feat(server): Make the health checker execution timeout recon…
414d5cf 
…figurable (#1754)

### What changes were proposed in this pull request?

1. Make the health checker execution timeout reconfigurable
2. Introduce the `rssConf.getReconfigurableConf` to use the reconfigurable conf.

### Why are the changes needed?

For #1711

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.
zuston added a commit to zuston/incubator-uniffle that referenced this issue Jun 3, 2024
@zuston
[apache#1711][FOLLOWUP] feat(coordinator): refactor the reconfigurabl…
52ccda9 
…e conf (apache#1741)

Refactor the reconfigurable conf for coordinator side.

Follow up: apache#1711

No.

Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1711] feat(server): Introduce the reconfigurable conf zuston/incubator-uniffle
1 participant
@zuston