[#1673] fix(K8S): Fix the deployment of stable version K8S cluster #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
============================================
- Coverage 54.86% 54.05% -0.81%
- Complexity 2358 2775 +417
============================================
Files 368 418 +50
Lines 16379 21821 +5442
Branches 1504 2054 +550
============================================
+ Hits 8986 11795 +2809
- Misses 6862 9280 +2418
- Partials 531 746 +215 ☔ View full report in Codecov by Sentry. |
jerqi
changed the title
|
cc @rickyma @zhengchenyu This is a break change for your deployment, please take a look |
advancedxy
reviewed
May 15, 2024
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go
Show resolved
Hide resolved
|
I verified this patch in the AWS EKS 1.28. It's ok. @advancedxy Could you approve this pull request? |
advancedxy
approved these changes
May 17, 2024
jerqi
added a commit
that referenced
this pull request
May 17, 2024
…1694) ### What changes were proposed in this pull request? 1. Upgrade Go to 1.19, Because mac brew doesn't support to install older than 1.19 Go. 2. Upgrade K8S api to 0.24. Because 1.24.1 supports to run the tests in the Mac M1 local machine and supports autoscaling/v2 api. 3. Change v2beta2 to v2 4. Use log4j2 instead of log4j ### Why are the changes needed? Kubernetes 1.26 removed the v2beta2 api of auto scaling. So our operator can't deployed some stable version K8S cluster. So I try to upgrade the version of the client. Compatible solution will be very difficult and bring more burden to maintain. So I choose to upgrade directly. If some users use low version, they can revert this pull request and compile again. Fix: #1673 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT + Manual test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Kubernetes 1.26 removed the v2beta2 api of auto scaling. So our operator can't deployed some stable version K8S cluster. So I try to upgrade the version of the client.
Compatible solution will be very difficult and bring more burden to maintain. So I choose to upgrade directly. If some users use low version, they can revert this pull request and compile again.
Fix: #1673
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT + Manual test.