Need support for imagePullSecrets while applying full-restart full-upgrade or deploying coordinator or shuffle server

[vinayakmalik95]

Need the support to download image from private repository while deploying coordinator & shuffle server.

Example while applying the webhook.yaml under the Kind: Deployment

I can mention imagePullSecrets

kind: Deployment
apiVersion: apps/v1
metadata:
name: rss-webhook
namespace: rss-system
spec:
strategy:
rollingUpdate:
maxSurge: 1
maxUnavailable: 2
type: RollingUpdate
selector:
matchLabels:
app: rss-webhook
replicas: 1
template:
metadata:
labels:
app: rss-webhook
service: rss-webhook
spec:
serviceAccountName: rss-webhook
containers:
- name: rss-webhook
image: xyz/rss-webhook:0.8.0-SNAPSHOT
command:
- "./webhook"
args:
- "--ignore-rss=false"
- "--v=4"
ports:
- containerPort: 9876
protocol: TCP
imagePullPolicy: "Always"
env:
- name: POD_NAME
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.name
- name: POD_NAMESPACE
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
resources:
requests:
cpu: 500m
memory: 1024Mi
imagePullSecrets:
- name: container-registry
tolerations:
- effect: NoSchedule
key: node-role.kubernetes.io/master
affinity:
podAntiAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
- labelSelector:
matchExpressions:
- key: app
operator: In
values:
- rss-webhook
topologyKey: kubernetes.io/hostname

But while applying the full-upgrade or applying coordinator or shuffleServer there is no support of imagePullSecrets.

apiVersion: uniffle.apache.org/v1alpha1
kind: RemoteShuffleService
metadata:
name: rss-full-upgrade-demo
namespace: rss-system
spec:
configMapName: rss-configuration
coordinator:
image: rss-server:0.8.0
initContainerImage: "busybox:latest"
rpcNodePort:
- 30001
- 30011
httpNodePort:
- 30002
- 30012
xmxSize: "2G"
count: 2
configDir: "/data/rssadmin/rss/conf"
replicas: 1
excludeNodesFilePath: "/data/rssadmin/rss/coo/exclude_nodes"
securityContext:
runAsUser: 1000
fsGroup: 1000
logHostPath: "/data/logs/rss/coordinator"
hostPathMounts:
/data/logs/rss/coordinator: /data/rssadmin/rss/logs
shuffleServer:
sync: true
replicas: 3
image: rss-server:0.8.0-SNAPSHOT
initContainerImage: "busybox:latest"
upgradeStrategy:
type: "FullUpgrade"
xmxSize: "2G"
configDir: "/data/rssadmin/rss/conf"
securityContext:
runAsUser: 1000
fsGroup: 1000
logHostPath: "/data/logs/rss/shuffle-server"
hostPathMounts:
/data/logs/rss/shuffle-server: /data/rssadmin/rss/logs
/data/rssenv1/rssdata1: /data1
/data/rssenv1/rssdata2: /data2
/data/rssenv1/rssdata3: /data3

[vinayakmalik95]

@jerqi please suggest

[jerqi]

According @wangao1236 's suggestion, it's ok for us. You can raise a pr to fix this issue.

[wangao1236]

It‘s ok for me. If possible, could you please help submit a PR? @vinayakmalik95

[vinayakmalik95]

sure.

let me know what I have to do next

[vinayakmalik95]

@wangao1236 which option I should select shown in image below?

[jerqi]

@wangao1236 which option I should select shown in image below?

1. Improvemnt is ok.

[jerqi]

You can see https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md

[vinayakmalik95]

Thanks @jerqi .

I have submitted an issue, here is the link
#716

I am not aware of how to implement the imagePullSecrets changes thus can not submit a PR myself. Waiting for you & @wangao1236 to help.