Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfigMap and Secret support #15

Closed
ptyin opened this issue Jan 30, 2024 · 0 comments · Fixed by #17
Closed

Add ConfigMap and Secret support #15

ptyin opened this issue Jan 30, 2024 · 0 comments · Fixed by #17
Assignees
@ptyin
Labels
good first issue Good for newcomers

Comments

@ptyin
Copy link
Member

ptyin commented Jan 30, 2024 •
edited

The present method to configure SeataServer is to use env property like following,

apiVersion: operator.seata.apache.org/v1alpha1
kind: SeataServer
# ...
spec:
  # ...
  env:
    console.user.username: seata
    console.user.password: seata

However, the env property is just a map, it does not support valueFrom like Kubernetes EnvVar. We would like to refactor the current env implementation from map type to EnvVar so to support ConfigMap and Secret. The expected form is something like following,

apiVersion: operator.seata.apache.org/v1alpha1
kind: SeataServer
# ...
spec:
  # ...
  env:
  - name: console.user.username
    value: seata
  - name: console.user.password
    valueFrom:
       secretKeyRef:
         name: seatapwd
         key: console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptyin ptyin

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: support ConfigMap and Secret by changing env from map to EnvVar ptyin/seata-k8s
1 participant
@ptyin