Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug(pd-store)] hstore backend core tests failure #2420

Open
VGalaxies opened this issue Jan 18, 2024 · 4 comments
Open

[Bug(pd-store)] hstore backend core tests failure #2420

VGalaxies opened this issue Jan 18, 2024 · 4 comments
Assignees
Labels
bug Something isn't working ci-cd Build or deploy hstore Hstore backend tests Add or improve test cases

Comments

@VGalaxies
Copy link
Contributor

VGalaxies commented Jan 18, 2024

subtask of #2265, see https://github.com/apache/incubator-hugegraph/actions/runs/7531623523/job/20500585647?pr=2414

@VGalaxies VGalaxies self-assigned this Jan 18, 2024
Copy link

dosubot bot commented Jan 18, 2024

🤖

Based on the provided context, it appears that the hstore core tests are failing due to several exceptions being thrown. These exceptions are related to the creation, scheduling, and deletion of tasks in the HugeGraph database.

The specific errors are as follows:

  1. IllegalArgumentException: Thrown when trying to delete an incomplete task.
  2. IllegalArgumentException: Thrown when a HugeTask is created with a null id.
  3. IllegalArgumentException: Thrown when a HugeTask is created with an id of invalid type.
  4. NullPointerException: Thrown when a HugeTask is created with a null callable.
  5. IllegalStateException: Thrown when a HugeTask is scheduled without setting a task type.
  6. IllegalStateException: Thrown when a HugeTask is scheduled without setting a task name.
  7. NotFoundException: Thrown when trying to access a task that has been deleted.

These errors are found in the testTask and testTaskWithFailure methods in the TaskCoreTest.java file.

Unfortunately, without more information, it's difficult to determine the exact cause of these test failures. The pull request #2414 and its potential impact on the hstore core tests, as well as the interaction between the pd-store and the hstore core tests, are not clear from the provided context.

If you could provide more details about the changes made in the pull request #2414, or any known issues or bugs in the pd-store that could have caused these test failures, it would be helpful in diagnosing the problem.

For more information about the purpose of the hstore core tests and the scenarios they cover, you can refer to the TaskCoreTest.java file in the incubator-hugegraph repository.

I hope this information is helpful. If you have any further questions or need more assistance, please don't hesitate to ask.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@VGalaxies VGalaxies changed the title hstore core tests failure fix(pd-store): hstore core tests failure Jan 18, 2024
@VGalaxies VGalaxies removed their assignment Jan 18, 2024
@dosubot dosubot bot added bug Something isn't working ci-cd Build or deploy tests Add or improve test cases labels Jan 18, 2024
@VGalaxies VGalaxies added the hstore Hstore backend label Jan 18, 2024
@VGalaxies VGalaxies changed the title fix(pd-store): hstore core tests failure [Bug(pd-store)] hstore core tests failure Jan 18, 2024
@VGalaxies VGalaxies changed the title [Bug(pd-store)] hstore core tests failure [Bug(pd-store)] hstore backend core tests failure Jan 18, 2024
@Pengzna
Copy link
Contributor

Pengzna commented Jan 18, 2024

I will try to catch it

@VGalaxies

This comment was marked as outdated.

@VGalaxies
Copy link
Contributor Author

VGalaxies commented Feb 27, 2024

NOTE: the core tests of hstore expect the following tests to fail:

Failures:
  EdgeCoreTest.testScanEdgeInPaging:5214 expected:<18> but was:<0>
  MultiGraphsTest.testCopySchemaWithMultiGraphs:121
  VertexCoreTest.testAddOlapRangeAndOlapSecondaryProperties:2491 expected:<1> but was:<0>
  VertexCoreTest.testAddOlapRangeProperties:2344 expected:<1> but was:<0>
  VertexCoreTest.testAddOlapSecondaryProperties:2254 expected:<1> but was:<0>
  VertexCoreTest.testQueryOlapRangeAndRegularSecondaryProperties:2638 expected:<1> but was:<0>
  VertexCoreTest.testQueryOlapWithUpdates:2725 expected:<1> but was:<0>
  VertexCoreTest.testScanVertexInPaging:7606 expected:<10> but was:<1>
Errors:
  EdgeCoreTest.testQueryOutEdgesOfVertexBySortkeyWithMoreFields:3912 » HgStoreClient
  EdgeCoreTest.testQueryOutEdgesOfVertexBySortkeyWithMoreFieldsInPage:4131 » HgStoreClient
  EdgeCoreTest.testQueryOutEdgesOfVertexBySortkeyWithPrefix:3704 » HgStoreClient
  EdgeCoreTest.testQueryOutEdgesOfVertexBySortkeyWithPrefixInPage:3800 » HgStoreClient
  EdgeCoreTest.testQueryOutEdgesOfVertexBySortkeyWithRange:3607 » HgStoreClient ...
  MultiGraphsTest.testCreateGraphWithSameNameDifferentBackends:289->openGraphWithBackend:381 » Runtime
  RamTableTest.testReloadAndQuery:112 » Huge Failed to load ramtable
  RamTableTest.testReloadAndQueryWithBigVertex:369 » Huge Failed to load ramtabl...
  RamTableTest.testReloadAndQueryWithMultiEdges:239 » Huge Failed to load ramtab...
  RamTableTest.testReloadAndQueryWithProperty:444 » Huge Failed to load ramtable
  RamTableTest.testReloadFromFileAndQuery:159 » Huge Failed to load ramtable
  VertexCoreTest.testQueryByPropertyInPageWithLimitGtPageSize:8337 » IllegalArgument
  VertexCoreTest.testQueryByRangeIndexInPage:8568 » IllegalArgument Undefined in...
  VertexCoreTest.testQueryBySingleRangePropertyInPage:8423 » IllegalArgument Und...
  • Clearing the cache before each test allows all tests in MultiGraphsTest to pass, but other tests fail extensively.
  • The NPE tests in HgStoreClient occur because the HugeGraph parameter passed during the construction of HugeVertex or HugeEdge is null (the store module cannot obtain the graph object instance).
  • Tests related to OLAP in VertexCoreTest: Not adapted yet.
  • Tests related to page in VertexCoreTest and EdgeCoreTest: Inconsistency in the definition of position between RocksDB scan iterator and Hstore.
  • Some RamTableTest cases: The ramtable feature is not supported by the hstore backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-cd Build or deploy hstore Hstore backend tests Add or improve test cases
Projects
Status: In progress
Development

No branches or pull requests

2 participants