Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][GitHub] LOC additions/deletions are wrong for the first commit in the specified time range #7426

Closed
2 of 3 tasks
antomer opened this issue May 6, 2024 · 1 comment · Fixed by #7458
Closed
2 of 3 tasks
Assignees
Labels
severity/p1 This bug affects functionality or significantly affect ux type/bug This issue is a bug
Milestone

Comments

@antomer
Copy link

antomer commented May 6, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Noticed some weird data in the commits table, some commits have random huge numbers for additions/deletions, for example, 182511 lines added, but in reality commit has only 7 lines added, moreover, if I fetch commit data from GitHub rest API it also shows correct data - 7 lines added.

such incorrect data screws up the PR size metric

re-collect data in full refresh mode doesn't help.

Slack thread

What do you expect to happen

Expect additions/deletions to be correct

How to reproduce

  1. create a new project
  2. add a new GitHub data scope for repository (should have some commits)
  3. add new data scope from 2. to project from 1. with sync time to be later than first commits in the repo
  4. trigger data collection
  5. observe that in commits table additions entry for the oldest collected commit are incorrect, seems like they include total amount of LOC in the repo.

Anything else

No response

Version

1.0.0-beta5

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@antomer antomer added the type/bug This issue is a bug label May 6, 2024
@antomer antomer changed the title [Bug][GitHub] Random entries in commits table has incorrect nr additions/deletions [Bug][GitHub] LOC additions/deletions are wrong for the first commit in the specified time range May 6, 2024
@Startrekzky
Copy link
Contributor

Hi, we'll fix it soon.

@Startrekzky Startrekzky added this to the v1.0 milestone May 7, 2024
@klesh klesh added the severity/p1 This bug affects functionality or significantly affect ux label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/p1 This bug affects functionality or significantly affect ux type/bug This issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants