Fix 909 Update initial data #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I just pushed the commit that updates initial data. few of the tests fails because it has a --- FAIL: Test_tagListRepo_BatchGetObjectTagRelList (0.00s)
tag_rel_repo_test.go:65:
Error Trace: /home/zahash/source/incubator-answer/internal/repo/repo_test/tag_rel_repo_test.go:65
Error: Not equal:
expected: 2
actual : 3
Test: Test_tagListRepo_BatchGetObjectTagRelList
[xorm] [info] 2024/04/23 20:21:07.437924 [SQL] SELECT count(*) FROM `tag_rel` WHERE `tag_id`=? AND `status`=? [10030000000000001 1] - 77.627µs
--- FAIL: Test_tagListRepo_CountTagRelByTagID (0.00s)
tag_rel_repo_test.go:73:
Error Trace: /home/zahash/source/incubator-answer/internal/repo/repo_test/tag_rel_repo_test.go:73
Error: Not equal:
expected: 1
actual : 3
Test: Test_tagListRepo_CountTagRelByTagID
--- FAIL: Test_tagListRepo_GetObjectTagRelWithoutStatus (0.00s)
tag_rel_repo_test.go:93:
Error Trace: /home/zahash/source/incubator-answer/internal/repo/repo_test/tag_rel_repo_test.go:93
Error: Not equal:
expected: 2
actual : 3
Test: Test_tagListRepo_GetObjectTagRelWithoutStatus
tag_rel_repo_test.go:101:
Error Trace: /home/zahash/source/incubator-answer/internal/repo/repo_test/tag_rel_repo_test.go:101
Error: Not equal:
expected: 0
actual : 1
Test: Test_tagListRepo_GetObjectTagRelWithoutStatus
tag_rel_repo_test.go:112:
Error Trace: /home/zahash/source/incubator-answer/internal/repo/repo_test/tag_rel_repo_test.go:112
Error: Not equal:
expected: 1
actual : 3
Test: Test_tagListRepo_GetObjectTagRelWithoutStatus
|
|
the enhancement is done and ready for review. |
LinkinStars
requested changes
Apr 24, 2024
internal/migrations/init.go
Outdated
| } | ||
|
|
||
| _, m.err = m.engine.Context(m.ctx).Insert(entity.TagRel{ | ||
| CreatedAt: now, |
There was a problem hiding this comment.
Just like below, no need to set the time here.
internal/migrations/init.go
Outdated
| Title: "What is a tag?", | ||
| OriginalText: "When asking a question, we need to choose tags. What are tags and why should I use them?", | ||
| ParsedText: "<p>When asking a question, we need to choose tags. What are tags and why should I use them?</p>", | ||
| Pin: entity.QuestionPin, |
There was a problem hiding this comment.
The questions don't need to be pinned to the top.
internal/migrations/init.go
Outdated
| Show: entity.QuestionShow, | ||
| Status: entity.QuestionStatusAvailable, | ||
| AnswerCount: 1, | ||
| AcceptedAnswerID: a1_id, |
There was a problem hiding this comment.
The answer corresponding to the question does not need to be accepted.
internal/migrations/init.go
Outdated
| Title: "What is reputation and how do I earn them?", | ||
| OriginalText: "I see that each user has reputation points, What is it and how do I earn them?", | ||
| ParsedText: "<p>I see that each user has reputation points, What is it and how do I earn them?</p>", | ||
| Pin: entity.QuestionPin, |
There was a problem hiding this comment.
The questions don't need to be pinned to the top.
internal/migrations/init.go
Outdated
| Show: entity.QuestionShow, | ||
| Status: entity.QuestionStatusAvailable, | ||
| AnswerCount: 1, | ||
| AcceptedAnswerID: a2_id, |
There was a problem hiding this comment.
The answer corresponding to the question does not need to be accepted.
|
i think i resolved all the code change requests. can you check? |
|
Great. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #909