Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin able to update email of user #853

Open
surapuramakhil opened this issue Mar 15, 2024 · 9 comments
Open

Admin able to update email of user #853

surapuramakhil opened this issue Mar 15, 2024 · 9 comments
Assignees
Labels
duplicate This issue or pull request already exists enhancement Enhancement request
Milestone

Comments

@surapuramakhil
Copy link
Contributor

Is your enhancement request related to a problem? Please describe

On Explicit requests when user wishes to change email of their account they can request admin to do so.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

@surapuramakhil surapuramakhil added the enhancement Enhancement request label Mar 15, 2024
@Octobug
Copy link
Contributor

Octobug commented Mar 25, 2024

It appears to be a sub-issue of #346

@surapuramakhil
Copy link
Contributor Author

@Octobug Yeah I got what you mean. But the deterrence is email serves as user identity (i.e. email ID must be unique) and another difference is user won't be able to do this (I don't recommend users to change their email directly, that's why suggested admin route)

I agree in terms of implementation, its sub-set of a feature.

@Octobug
Copy link
Contributor

Octobug commented Mar 25, 2024

@Octobug Yeah I got what you mean. But the deterrence is email serves as user identity (i.e. email ID must be unique) and another difference is user won't be able to do this (I don't recommend users to change their email directly, that's why suggested admin route)

I agree in terms of implementation, its sub-set of a feature.

Yes, this issue does need more consideration. This "Explicit requests" process requires some security mechanism to prove that a request is sent by the true owner of that account. An admin cannot simply change email for a user when he receives a request.

As for #346 , it lets the admin do that change when the admin is confident about the changing. It doesn't involve the aspect of how a user proves who he is.

@surapuramakhil
Copy link
Contributor Author

This "Explicit requests" process requires some security mechanism to prove that a request is sent by the true owner of that account. An admin cannot simply change email for a user when he receives a request.

@Octobug Ah, I didn't say that you expressed that in #853 (comment). Even this #853 doesn't involve the aspect of how a user proves who he is.

Email is treated separately as it has more purpose compared to other data like name, profile picture and bio.

@Octobug
Copy link
Contributor

Octobug commented Mar 25, 2024

@surapuramakhil I just suddenly realized that there might be security issues in the request process. Sorry to confuse you. 😂

@surapuramakhil
Copy link
Contributor Author

Admin processing approval process off system. So admin needs to handle security issues 😂
Even today admin can do this by DB udpated. This feature just saves their life.

@fenbox
Copy link
Member

fenbox commented Mar 26, 2024

Email and username must be unique, modifying the database directly can be dangerous. Add the "Edith profile" menu in Admin -> Users for easy solving.

image

image

@fenbox fenbox modified the milestone: v1.3.1 Mar 26, 2024
@fenbox fenbox added the duplicate This issue or pull request already exists label Mar 26, 2024
@fenbox fenbox added this to the v1.3.1 milestone Mar 26, 2024
@prithvidasgupta
Copy link
Contributor

@fenbox I would like to work on this.

Should the end user receive a notification about this? Also, what should be the I8n guidelines for the new text?

@LinkinStars
Copy link
Member

@fenbox I would like to work on this.

Should the end user receive a notification about this? Also, what should be the I8n guidelines for the new text?

@prithvidasgupta This feature is an operation where the administrator enforces changes, which can be modified directly. So, there is no need to notify the user or send an email confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement Enhancement request
Projects
Status: Todo
Development

No branches or pull requests

5 participants