Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t find/highlight text inside <textarea> elements (or other invalid parents for a <mark>). #131

Open
Treora opened this issue Sep 15, 2022 · 2 comments
Labels
🦟 Bug Something isn't working

Comments

@Treora
Copy link
Contributor

Treora commented Sep 15, 2022

Highlighting (using <mark> elements, as we do) text inside a <textarea> will make that text disappear. The higlighter should either fail or modify the given range if parts of it are within a textarea.

This could be generalised to any element where a <mark> element would not be permitted as a child.

@reckart
Copy link
Member

reckart commented Sep 15, 2022

Another case could be mathml sections or SVGs.

@Treora
Copy link
Contributor Author

Treora commented Dec 29, 2022

Yet another issue in this theme: table layout can be messed up by the added <mark> elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants