Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove unused RocketMQ dependencies in List rocketmq #4826

Open
2 of 3 tasks
Pil0tXia opened this issue Apr 11, 2024 · 7 comments
Open
2 of 3 tasks

[Enhancement] Remove unused RocketMQ dependencies in List rocketmq #4826

Pil0tXia opened this issue Apr 11, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Pil0tXia
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

As is described in #4719 (comment), there is no reference to the rocketmq-broker package in the code of eventmesh-connector-rocketmq module.

Describe the solution you'd like

  • In addition to the rocketmq-broker package, there are some packages that are not being used by the code.
  • In addition to the eventmesh-connector-rocketmq module, there some modules in which the same List rocketmq dependency set is being used.

Streamline dependencies not used by the code.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Pil0tXia Pil0tXia added enhancement New feature or request good first issue Issues for first-time contributors labels Apr 11, 2024
@heliang666s
Copy link

hello,I am new in there,I will try it,please assign me,thanks~

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Apr 16, 2024

@heliang666s Welcome! You can start your work after #4719 is merged.

@yangsl960702
Copy link

请问已经有人解决了吗

@Pil0tXia
Copy link
Member Author

Pil0tXia commented May 8, 2024

@heliang666s #4719 has been merged already.

@yangsl960702
Copy link

@heliang666s #4719 has been merged already.

ok,如果后续有新的简单的希望有机会

@Pil0tXia
Copy link
Member Author

Pil0tXia commented May 8, 2024

@yangsl960702 You can check out the Good first issue list, there are a lot of issues for freshmen.

@yangsl960702
Copy link

@yangsl960702你可以看看Good first issues list,有很多适合新生的问题。

好的好的,非常感谢你,感动

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Development

No branches or pull requests

3 participants