Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use YAML file to store configuration #481

Open
ruanwenjun opened this issue Aug 3, 2021 · 3 comments · May be fixed by #3988
Open

Use YAML file to store configuration #481

ruanwenjun opened this issue Aug 3, 2021 · 3 comments · May be fixed by #3988
Labels
enhancement New feature or request Stale

Comments

@ruanwenjun
Copy link
Member

Enhancement Request

Currently, there are a lot of configuration fields in EventMesh, and it will increase in the future, you can look up at eventmesh.properties.
Such as:

eventMesh.server.idc=DEFAULT
eventMesh.server.env=PRD
eventMesh.server.cluster=COMMON
eventMesh.server.name=EVENTMESH-runtime
eventMesh.sysid=0000
eventMesh.server.http.port=10105
########################## eventMesh tcp configuration ############################
eventMesh.server.tcp.enabled=true
eventMesh.server.tcp.port=10000
eventMesh.server.tcp.readerIdleSeconds=120
eventMesh.server.tcp.writerIdleSeconds=120
eventMesh.server.tcp.allIdleSeconds=120
eventMesh.server.tcp.clientMaxNum=10000
# client isolation time if the message send failure
eventMesh.server.tcp.pushFailIsolateTimeInMills=30000

It is difficult to find out which is your want since most of them has the same prefix.
It is better to store them at yaml file, the advantage is that you can merge the common prefixes like below:

eventMesh:
  server:
    idc: DEFAULT
    env: PRD
    cluster: COMMON
    name: EVENTMESH-runtime
    http:
      port: 10105
    tcp:
      enabled: true
      port: 10000
      readerIdleSeconds: 120
      writerIdleSeconds: 120
      allIdleSeconds: 120
      clientMaxNum: 10000
      pushFailIsolateTimeInMills: 30000 # client isolation time if the message send failure
  sysid: 0000
@ruanwenjun ruanwenjun added the enhancement New feature or request label Aug 3, 2021
@qqeasonchen
Copy link
Contributor

good suggestion

@Jackzeng1224
Copy link

It can be revised and submitted to pr

@pandaapo pandaapo linked a pull request May 21, 2023 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

@github-actions github-actions bot added the Stale label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #481] Use YAML file to store configuration pandaapo/eventmesh
3 participants
@ruanwenjun @qqeasonchen @Jackzeng1224