-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: that protoc-gen-go-triple cannot generate normally when a proto file has multiple services. #2647
Conversation
…file has multiple services.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
==========================================
+ Coverage 47.38% 47.40% +0.02%
==========================================
Files 341 341
Lines 25122 25125 +3
==========================================
+ Hits 11904 11911 +7
+ Misses 12074 12069 -5
- Partials 1144 1145 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a testcase to verify your change?
…: undefined: descriptorpb.Default_FileOptions_PhpGenericServices.
Quality Gate passedIssues Measures |
The whole protoc plugin has been moved to a separate repo. I will merge this change first and move the source code there. |
…file has multiple services. (apache#2647) fixed apache#2646
fixed #2646