Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple OpenTelemetry support #2554

Open
DMwangnima opened this issue Jan 2, 2024 · 0 comments
Open

Triple OpenTelemetry support #2554

DMwangnima opened this issue Jan 2, 2024 · 0 comments
Milestone

Comments

@DMwangnima
Copy link
Contributor

DMwangnima commented Jan 2, 2024

What would you like to be added:

Triple OpenTelemetry support:

  1. Consider a better way to inject OpenTelemetry configurations to Triple protocol adaptation layer(/protocol/triple). For old Triple(/protocol/dubbo3), it retrieves configurations from config package directly. It is not a good design.

  2. Implement OpenTelemetry Interceptor for Triple protocol. You can refer to this part(https://connectrpc.com/docs/go/observability). But there are some differences between Triple protocol and connect-go.

  3. Tests implementation

For Triple protocol adaptation part, Please design tests to verify that OpenTelemetry configurations have been injected successfully and the necessary information in these configurations have been processed well. You can add tests in /protocol/triple/triple_test.go or some place more ideal.

For Triple protocol part, It is a good chance to learn the details about this protocol from outside to inside. You should write some unit tests to verify that OpenTelemetry Interceptor has been configured successfully and this functionality works well in the context of Triple protocol.

For dubbo-go-samples(Integration test), please refer to /tracing directory and write new tests using new API.

@DMwangnima DMwangnima changed the title Triple Open Tracing support Triple OpenTelemetry support Jan 2, 2024
@chickenlj chickenlj added this to the v3.2.0-rc2 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants