Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid argument error: lz4 IPC decompression requires the lz4 feature #929

Open
andygrove opened this issue Dec 11, 2023 · 8 comments
Open
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

Describe the bug

I am trying to run queries with Ballista but I get this error on the client.

Fail: Arrow error: Invalid argument error: lz4 IPC decompression requires the lz4 feature

I am not yet sure where this is coming from.

I do not see any lz4 feature in the Ballista Cargo.toml files.

To Reproduce

Expected behavior

Additional context

@andygrove andygrove added the bug Something isn't working label Dec 11, 2023
@andygrove
Copy link
Member Author

@Dandandan Any suggestions on tracking this down?

@Dandandan
Copy link
Contributor

Dandandan commented Dec 11, 2023

You can enable lz4 compression support via ipc_compression feature flag of arrow.

@Dandandan
Copy link
Contributor

Hm but this seems to be currently enabled, are you somehow running a version without ipc_compression set?

@andygrove
Copy link
Member Author

I built Ballista from this PR with cargo build --release.

My client is at datafusion-contrib/sqlbench-runners#32 and has these dependencies:

[dependencies]
ballista = { git = "https://github.com/andygrove/arrow-ballista", branch="df-34" }
datafusion = { git = "https://github.com/apache/arrow-datafusion", rev = "d091b55be6a4ce552023ef162b5d081136d3ff6d" }

It has been a long time since I worked on this project so maybe I am just missing something obvious.

@Dandandan
Copy link
Contributor

Is the branch compiling already?
Seems it might not and you might be running an older (cached) version maybe?
https://github.com/andygrove/arrow-ballista/actions/runs/7169227281/job/19519719152#step:8:443

@andygrove
Copy link
Member Author

Is the branch compiling already?

Yes, it was just the tests that weren't compiling in CI. I pushed a fix. I ran a cargo clean locally on ballista and my client and still see the same issue.

@Dandandan
Copy link
Contributor

Is the branch compiling already?

Yes, it was just the tests that weren't compiling in CI. I pushed a fix. I ran a cargo clean locally on ballista and my client and still see the same issue.

Does enabling it in the sqlbenchrunner as well by explicitly adding arrow dependency with ipc_compression work?

@andygrove
Copy link
Member Author

Does enabling it in the sqlbenchrunner as well by explicitly adding arrow dependency with ipc_compression work?

Yes, that fixed it, thanks. I can create a PR to add this to the documentation, but it would be nice if this weren't needed. Shouldn't Ballista enable this feature in the arrow dependency by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants